Geometric Contact Potential #191
Open
+26,993
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed tangents.cpp and tangents.hpp from the IPC utility source files. - Deleted finitediff.hpp as it was no longer needed. - Updated MatrixCache.cpp to improve variable naming for clarity and consistency. - Cleaned up CMakeLists.txt by removing references to tangents files. - Deleted obsolete test data files related to nonlinear solve iterations and simple 2D cases. - Adjusted test configurations to point to the correct data directory structure.
zfergus
requested changes
Oct 9, 2025
src/ipc/distance/distance_type.hpp
Outdated
|
|
||
| /// @brief Closest pair between a point and point. | ||
| enum class PointPointDistanceType { | ||
| AUTO ///< Automatically determine the closest pair. |
- Changed `constexpr static` to `static constexpr` for consistency - Updated member variable naming to match convention - Renamed and updated include paths for utility headers to follow a consistent naming scheme (e.g., MaybeParallelFor.hpp to maybe_parallel_for.hpp). - Removed par_for.hpp and par_for.cpp files
zfergus
reviewed
Oct 11, 2025
zfergus
reviewed
Oct 11, 2025
| /// @brief Face-vertex tangential collisions. | ||
| std::vector<FaceVertexTangentialCollision> fv_collisions; | ||
|
|
||
| double barrier_stiffness_; |
There was a problem hiding this comment.
Should this really be here? Perhaps its better place in the TangentialPotential class?
zfergus
reviewed
Oct 11, 2025
| /// @brief Normal force magnitude | ||
| double normal_force_magnitude = 0; | ||
|
|
||
| std::shared_ptr<SmoothCollision> smooth_collision = nullptr; |
zfergus
reviewed
Oct 11, 2025
| const std::function<double(double, double)>& blend_mu = | ||
| default_blend_mu); | ||
|
|
||
| void build_for_smooth_contact( |
…rove parameter naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of Siggraph 2025 paper Geometric Contact Potential. The implementation includes the collision and friction potential, their gradient and Hessian.
Type of change
Please delete options that are not relevant.
Checklist